Add module #1
Merged
Add module #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswrz
requested changes
Jul 23, 2024
rswrz
reviewed
Jul 25, 2024
Phil-Thoennissen
force-pushed
the
add_module
branch
from
ae01eba
to
078e967
Compare
Phil-Thoennissen
force-pushed
the
add_module
branch
2 times, most recently
from
cfbae89
to
1121835
Compare
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]> Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: Roman Schwarz <[email protected]> Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Phil-Thoennissen
force-pushed
the
add_module
branch
from
10ae4df
to
7d81d66
Compare
Signed-off-by: philthoennissen <[email protected]>
rswrz
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Thank you for developing this module! I've added some comments and recommendations in my review. Please take these as constructive feedback aimed at improving the module. They are based on the Terraform Module Style Guide, which is currently under development.
If you'd like, we can discuss the individual points in a meeting.
- Please remove the empty
main.tffile after splitting resources into multiple files. - Ensure all references to renamed resources and data sources are updated accordingly.
- Rename the
tests/local/mock_providersdirectory totests/local/mocksfor consistency. - Please also use the latest module-ci.yaml workflow. This workflow also runs all tests (example, local, remote), and this would fail in this PR.
I did not review the INSTALL.md for now. I will do this as soon as the module is working.
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
lixhunter
requested changes
Oct 8, 2024
Quick Fix for several suggestions Co-authored-by: Andre Licht <[email protected]> Signed-off-by: Phil-Thoennissen <[email protected]>
rswrz
reviewed
Oct 11, 2024
rswrz
requested changes
Oct 11, 2024
|
As a side note, the remote test failed. |
lixhunter
previously approved these changes
Oct 11, 2024
Signed-off-by: philthoennissen <[email protected]>
Co-authored-by: Roman Schwarz <[email protected]> Signed-off-by: Phil-Thoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
|
@rswrz Everything should be done now and pipelines are green as well. |
|
Hey @Phil-Thoennissen, I’ve noticed that the Storage Account (also in the upstream Launchpad Terraform code) allows Blob Public Access by default. We should change this. Please set |
rswrz
requested changes
Oct 23, 2024
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
Signed-off-by: philthoennissen <[email protected]>
rswrz
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initital Module.
Please take a closer look at INSTALL.md line 52-60